This repository was archived by the owner on Aug 13, 2026. It is now read-only.
[Bug] Remove hardcoded component ids from link field definition panel - #1143
Closed
kingjia90 wants to merge 1 commit into
Closed
[Bug] Remove hardcoded component ids from link field definition panel#1143kingjia90 wants to merge 1 commit into
kingjia90 wants to merge 1 commit into
Conversation
Opening the class editor for multiple DataObjects/ObjectBricks containing link fields at the same time failed with "Ext.ComponentManager.register(): Duplicate component id 'allowedTypes'". The multiselects are identified by their form field name, the global ids are unused. Fixes pimcore/platform-version#169 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Contributor
There was a problem hiding this comment.
Pull request overview
Removes global ExtJS component IDs that caused duplicate-ID errors when multiple link field editors were open.
Changes:
- Removed seven hardcoded multiselect IDs.
- Preserved field names used for value collection.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Moved to the ee repo: https://github.com/pimcore/ee-admin-ui-classic-bundle/pull/395 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pimcore/platform-version#169
Creating/editing link fields in multiple
DataObjects/ObjectBricks at the same time failed with:The seven multiselects added in #1078 each carried a hardcoded global ExtJS
id:— opening a second class editor containing a link field registered the same component ids twice, breaking the panel.The values are collected via the form field
name, and none of the ids (allowedTypes,allowedAssetSubtypes,allowedDocumentSubtypes,allowedObjectSubtypes,allowedClasses,allowedTargets,disabledFields) is referenced anywhere in the bundle (Ext.getCmp/selector search), so they can simply be removed.Reproduction: open two class definitions each containing a link field (or a class and an object brick) in two tabs → second editor breaks. With this patch both render fine.