Skip to content

chore(repo): untrack target-stats/, 6,624 committed build artifacts - #590

Merged
TinDang97 merged 1 commit into
mainfrom
chore/untrack-target-stats
Aug 20, 2026
Merged

chore(repo): untrack target-stats/, 6,624 committed build artifacts#590
TinDang97 merged 1 commit into
mainfrom
chore/untrack-target-stats

Conversation

@TinDang97

Copy link
Copy Markdown
Collaborator

target-stats/ is a CARGO_TARGET_DIR committed by accident in #431. It is not gitignored, so all 6,624 of its build artifacts are tracked — 64% of the repo's 10,315 tracked files, roughly 1 GB.

Because they are tracked, git writes every one on every clone and every git worktree add. That is not cosmetic:

  • Two agent worktree creations failed outright today with No space left on device while git was writing target-stats/release-fast/deps/*.rlib.
  • The same full disk destroyed the OrbStack moon-dev VM, which made both VM legs of scripts/ci-local.sh report FAIL with zero failing tests — an infrastructure failure wearing the costume of a code failure. That is the most expensive part: it makes the local merge gate untrustworthy.
  • Every contributor pays ~1 GB of stale artifacts on clone, built with a 2026-08-04 toolchain, useless to anyone.

Change

  • git rm -r --cached target-stats — removes from the index; working-tree copies are build output, regenerated on demand.
  • Adds a target-*/ rule so no future CARGO_TARGET_DIR can be committed the same way. Existing narrow rules kept for clarity.

Verified before committing

check result
staged deletions 6,624
deletions outside target-stats/ 0
.rs source files deleted 0
references in Cargo.toml / .cargo/config.toml / scripts/ / .github/ none

No source, config, or CI file is touched. skip-changelog applies — this changes no product behaviour.

`target-stats/` is a CARGO_TARGET_DIR that was committed by accident in #431.
It is not in .gitignore, so all 6,624 of its build artifacts are tracked —
64% of the repository's 10,315 tracked files, roughly 1 GB.

Because they are tracked, git writes every one of them on every clone and on
every `git worktree add`. That is not a cosmetic problem:

- Two agent worktree creations failed outright today with "No space left on
  device" while git was writing target-stats/release-fast/deps/*.rlib.
- The same full disk took out the OrbStack moon-dev VM, which made both VM
  legs of scripts/ci-local.sh report FAIL with zero failing tests — an
  infrastructure failure wearing the costume of a code failure.
- Every contributor pays ~1 GB of stale artifacts on clone, and the artifacts
  are from a 2026-08-04 toolchain, so they are useless to anyone.

This removes them from the index (the working-tree copies are build output and
are regenerated on demand) and adds a `target-*/` rule so no future
CARGO_TARGET_DIR can be committed the same way. The existing narrow rules are
kept for clarity.

Verified before committing:
- 6,624 staged deletions, of which 0 are outside target-stats/
- no .rs source file is deleted
- nothing in Cargo.toml, .cargo/config.toml, scripts/, or .github/ references
  target-stats

author: Tin Dang
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@TinDang97 TinDang97 added the skip-changelog Skip the CHANGELOG.md update gate for this PR label Aug 20, 2026
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Caution

CodeRabbit couldn't post its review summary.

Error details
Validation Failed: {"resource":"IssueComment","code":"unprocessable","field":"data","message":"Body is too long (maximum is 65536 characters)"} - https://docs.github.com/rest/issues/comments#create-an-issue-comment

@TinDang97
TinDang97 merged commit a9cbf78 into main Aug 20, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Skip the CHANGELOG.md update gate for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant