fix(passage): port the stimulus-tabs theming fix from upstream PIE-818 - #76
Merged
Merged
Conversation
Carries pie-elements 5c499e1e3 into the generated element: the paired-passage tab fill, ink and selection indicator move off MUI's palette onto `color.background()` / `color.text()`, the two `#D9DADA` borders onto `color.borderGray()`, and the strip's no-host fallback from a white literal onto `color.backgroundDark()`. See that commit for why each one moved. Produced by `upstream:sync --element passage` against a local pie-elements checkout, so it will regenerate identically once the upstream branch merges. The sync also rewrote two unrelated things in this package which were reverted rather than shipped: it downgraded `vite` from `^8.1.5` to `^8.0.1` in the package's devDependencies and `bun.lock`, and it dropped the `element-legacy-print.config.ts` step from the build script. Both are newer here than the template the sync writes, so a full `upstream:sync` will reintroduce them until the template catches up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries pie-elements 5c499e1e3 into the generated element: the paired-passage tab fill, ink
and selection indicator move off MUI's palette onto
color.background()/color.text(),the two
#D9DADAborders ontocolor.borderGray(), and the strip's no-host fallback from awhite literal onto
color.backgroundDark(). See that commit for why each one moved.Produced by
upstream:sync --element passageagainst a local pie-elements checkout, so itwill regenerate identically once the upstream branch merges. The sync also rewrote two
unrelated things in this package which were reverted rather than shipped: it downgraded
vitefrom^8.1.5to^8.0.1in the package's devDependencies andbun.lock, and itdropped the
element-legacy-print.config.tsstep from the build script. Both are newer herethan the template the sync writes, so a full
upstream:syncwill reintroduce them until thetemplate catches up.
Depends on pie-framework/pie-elements#3097. Merge that first; this branch already contains the
synced result, so re-running the sync after it lands is a no-op.
A changeset marks
@pie-element/passageas a patch.Verification
bun run buildpasses all four vite passes for the package and the tokens are present in thebundle. Not verified in a rendered dark scheme — reproducing the tabs needs a passage-pair item
from the datastore behind auth, and this package has no standalone demo page with a pair.