Skip to content

ext/dom: Fix INUSE_ATTRIBUTE_ERR message #23381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LamentXU123 merged 1 commit into from
Aug 19, 2026
+4 −2
Merged

ext/dom: Fix INUSE_ATTRIBUTE_ERR message #23381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ PHP NEWS
2GB on some platforms, e.g. Windows. (Sjoerd Langkemper)

- DOM:
. Fixed a typo in the DOMException message for INUSE_ATTRIBUTE_ERR.
(Weilin Du)
. Fixed bug GH-22624 (use-after-free via DOMNameSpaceNode after
DOMDocument::xinclude()). (David Carlier)
. Fixed a use-after-free when cloning a DOMNameSpaceNode after
Expand Down
2 changes: 1 addition & 1 deletion ext/dom/domexception.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ void php_dom_throw_error(dom_exception_code error_code, bool strict_error)
error_message = "Not Supported Error";
break;
case INUSE_ATTRIBUTE_ERR:
error_message = "Inuse Attribute Error";
error_message = "In Use Attribute Error";
break;
case INVALID_STATE_ERR:
error_message = "Invalid State Error";
Expand Down
2 changes: 1 addition & 1 deletion ext/dom/tests/modern/spec/Element_setAttributeNode_inuse.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ echo $dom1->saveHtml(), "\n";

?>
--EXPECT--
Inuse Attribute Error
In Use Attribute Error
<container my-attribute="1"><element></element></container>
Loading