Skip to content

ext/xmlwriter: applied fixers to improve test robustness #23026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Girgias merged 1 commit into from
Aug 22, 2026
Merged

ext/xmlwriter: applied fixers to improve test robustness #23026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ext/xmlwriter/tests/010.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,16 @@ var_dump(xmlwriter_end_attribute($xw));

try {
xmlwriter_start_attribute($xw, "-1");
} catch (ValueError $e) {
echo $e->getMessage(), "\n";
} catch (Throwable $e) {
echo $e::class, ': ', $e->getMessage(), "\n";
}

var_dump(xmlwriter_end_attribute($xw));

try {
xmlwriter_start_attribute($xw, "\"");
} catch (ValueError $e) {
echo $e->getMessage(), "\n";
} catch (Throwable $e) {
echo $e::class, ': ', $e->getMessage(), "\n";
}

var_dump(xmlwriter_end_attribute($xw));
Expand All @@ -45,9 +45,9 @@ echo "Done\n";
bool(true)
bool(true)
bool(true)
xmlwriter_start_attribute(): Argument #2 ($name) must be a valid attribute name, "-1" given
ValueError: xmlwriter_start_attribute(): Argument #2 ($name) must be a valid attribute name, "-1" given
bool(false)
xmlwriter_start_attribute(): Argument #2 ($name) must be a valid attribute name, """ given
ValueError: xmlwriter_start_attribute(): Argument #2 ($name) must be a valid attribute name, """ given
bool(false)
bool(true)
string(14) "<tag attr=""/>"
Expand Down
6 changes: 3 additions & 3 deletions ext/xmlwriter/tests/xmlwriter_open_uri_error_001.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ xmlwriter
<?php
try {
xmlwriter_open_uri('');
} catch (ValueError $exception) {
echo $exception->getMessage() . "\n";
} catch (Throwable $exception) {
echo $exception::class, ': ', $exception->getMessage(), "\n";
}
?>
--CREDITS--
Koen Kuipers koenk82@gmail.com
Theo van der Zee
#Test Fest Utrecht 09-05-2009
--EXPECT--
xmlwriter_open_uri(): Argument #1 ($uri) must not be empty
ValueError: xmlwriter_open_uri(): Argument #1 ($uri) must not be empty
4 changes: 2 additions & 2 deletions ext/xmlwriter/tests/xmlwriter_toMemory_custom_constructor_error.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ class CustomXMLWriter extends XMLWriter {
try {
CustomXMLWriter::toMemory();
} catch (Throwable $e) {
echo $e->getMessage(), "\n";
echo $e::class, ': ', $e->getMessage(), "\n";
}

?>
--EXPECT--
nope
Error: nope
4 changes: 2 additions & 2 deletions ext/xmlwriter/tests/xmlwriter_toStream_custom_constructor_error.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ $h = fopen("php://output", "w");
try {
CustomXMLWriter::toStream($h);
} catch (Throwable $e) {
echo $e->getMessage(), "\n";
echo $e::class, ': ', $e->getMessage(), "\n";
}

?>
--EXPECT--
nope
Error: nope
6 changes: 3 additions & 3 deletions ext/xmlwriter/tests/xmlwriter_toStream_open_invalidated_stream.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ fclose($h);

try {
XMLWriter::toStream($h);
} catch (TypeError $e) {
echo $e->getMessage(), "\n";
} catch (Throwable $e) {
echo $e::class, ': ', $e->getMessage(), "\n";
}

?>
--EXPECT--
XMLWriter::toStream(): supplied resource is not a valid stream resource
TypeError: XMLWriter::toStream(): supplied resource is not a valid stream resource
Loading