Skip to content

signal: Improve naming consistency: bs_signal_connect -> bs_listener_connect. #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phkaeser merged 1 commit into from
Aug 25, 2026
Merged

signal: Improve naming consistency: bs_signal_connect -> bs_listener_connect. #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions include/libbase/signal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,24 +69,24 @@ void bs_signal_emit(
/**
* Connects the listener with the provided notification function to the signal.
*
* @param signal_ptr
* @param listener_ptr
* @param notify
* @param signal_ptr
*/
void bs_signal_connect(
struct bs_signal *signal_ptr,
void bs_listener_connect(
struct bs_listener *listener_ptr,
bs_signal_notify_t notify);
bs_signal_notify_t notify,
struct bs_signal *signal_ptr);

/**
* Disconnects the listener from the signal.
*
* @param signal_ptr
* @param listener_ptr
* @param signal_ptr
*/
void bs_signal_disconnect(
struct bs_signal *signal_ptr,
struct bs_listener *listener_ptr);
void bs_listener_disconnect(
struct bs_listener *listener_ptr,
struct bs_signal *signal_ptr);

/** A listener that can be used in unit tests. */
struct bs_test_listener {
Expand Down
24 changes: 12 additions & 12 deletions src/signal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ void bs_signal_emit(
}

/* ------------------------------------------------------------------------- */
void bs_signal_connect(
struct bs_signal *signal_ptr,
void bs_listener_connect(
struct bs_listener *listener_ptr,
bs_signal_notify_t notify)
bs_signal_notify_t notify,
struct bs_signal *signal_ptr)
{
listener_ptr->notify = notify;
bs_dllist_push_back(
Expand All @@ -59,9 +59,9 @@ void bs_signal_connect(
}

/* ------------------------------------------------------------------------- */
void bs_signal_disconnect(
struct bs_signal *signal_ptr,
struct bs_listener *listener_ptr)
void bs_listener_disconnect(
struct bs_listener *listener_ptr,
struct bs_signal *signal_ptr)
{
bs_dllist_remove(
&signal_ptr->listeners,
Expand All @@ -81,20 +81,20 @@ void bs_test_listener_connect(
struct bs_signal *signal_ptr,
struct bs_test_listener *test_listener_ptr)
{
bs_signal_connect(
signal_ptr,
bs_listener_connect(
&test_listener_ptr->listener,
_bs_test_listener_notify);
_bs_test_listener_notify,
signal_ptr);
}

/* ------------------------------------------------------------------------- */
void bs_test_listener_disconnect(
struct bs_signal *signal_ptr,
struct bs_test_listener *test_listener_ptr)
{
bs_signal_disconnect(
signal_ptr,
&test_listener_ptr->listener);
bs_listener_disconnect(
&test_listener_ptr->listener,
signal_ptr);
}

/* == Local (static) methods =============================================== */
Expand Down
Loading