fix(release): give the credential preflight a registry to authenticate against - #13
Merged
Conversation
…e against The preflight added in the previous commit failed with ENEEDAUTH rather than reporting the account, because the verify job's setup-node had no registry-url. That option is what writes the .npmrc containing the NODE_AUTH_TOKEN reference; without it the token sits in the environment and npm never reads it. The publish jobs already pass registry-url, so this only ever affected the diagnostic — but a diagnostic that cannot authenticate answers nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preflight from #11 failed with
ENEEDAUTHinstead of reporting the account:registry-urlonactions/setup-nodeis what writes the.npmrccontaining theNODE_AUTH_TOKENreference. Theverifyjob didn't pass it, so the token was in the environment and npm ignored it.The publish jobs already set it, so this only affected the diagnostic — but a diagnostic that can't authenticate answers nothing, which is why the last run still didn't tell us who the token is.