Avoid unsafe intermediate slice construction in varlena functions - #2368
Open
SergeiPatiakin wants to merge 1 commit into
Open
Avoid unsafe intermediate slice construction in varlena functions#2368SergeiPatiakin wants to merge 1 commit into
SergeiPatiakin wants to merge 1 commit into
Conversation
0xPoe
approved these changes
Sep 2, 2026
0xPoe
left a comment
Contributor
There was a problem hiding this comment.
Although it doesn’t cause any issues now, it’s reasonable to fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unsafe __IncompleteArrayField<T>::as_slicecallsunsafe ::core::slice::from_raw_parts, which is UB if the slice memory range is invalid.But the length we pass in the
varlena_4b*cases isvarsize_1b(ptr)which is a garbage valuepotentially larger than the real length. Therefore the slice memory range can indeed be invalid.
I don't think this is a practical concern today because we immediately do
.as_ptronthe intermediate slice, but still looks like technically UB.