Use references in heap tuple helpers - #2367
Open
0xPoe wants to merge 1 commit into
Open
Conversation
0xPoe
commented
Aug 28, 2026
0xPoe
left a comment
0xPoe
left a comment
Contributor
Author
There was a problem hiding this comment.
🔢 Self-check (PR reviewed by myself and ready for feedback)
-
Code compiles successfully
-
Unit tests added
-
No AI-generated elegant nonsense in PR.
-
Comments added where necessary
-
PR title and description updated
-
PR size is reasonable
/cc @workingjubilee Not sure if you’re still available to review it. Thanks!
| pub unsafe fn heap_tuple_header_get_type_id( | ||
| htup_header: &pg_sys::HeapTupleHeaderData, | ||
| ) -> pg_sys::Oid { | ||
| unsafe { htup_header.t_choice.t_datum.datum_typeid } |
Contributor
Author
There was a problem hiding this comment.
Not sure whether we prefer to allow unsafe-op-in-unsafe-fn. I’m happy to change it.
Contributor
Author
There was a problem hiding this comment.
I saw the lint configuration, but I’m not sure whether we prefer not to use it at all or simply want to avoid too many noisy warnings.
0xPoe
force-pushed
the
refactor-htup-raw-pointers
branch
from
August 28, 2026 11:29
38c7d88 to
8a20aa5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace raw heap tuple pointer parameters with references, using
NonNullat the FFI boundary. Clarify the affected safety contracts.Testing
cargo fmt --all -- --checkcargo test -p pgrx --no-default-features --features pg18Refs #623