Skip to content

SPOCK-625: bump extension version to 2.6.0#42

Merged
mason-sharp merged 2 commits into
mainfrom
SPOCK-625-snowflake-extension-not-bumped
Jul 21, 2026
Merged

SPOCK-625: bump extension version to 2.6.0#42
mason-sharp merged 2 commits into
mainfrom
SPOCK-625-snowflake-extension-not-bumped

Conversation

@zaidshabbir25

@zaidshabbir25 zaidshabbir25 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

The v2.6.0 tag was cut without bumping the extension version metadata: snowflake.control still declared default_version = '2.5.0' and no 2.6.0 SQL script existed, so the extension installed and reported itself as 2.5.0 even when built from the v2.6.0 tag.

  • snowflake.control: default_version 2.5.0 -> 2.6.0
  • add snowflake--2.5.0--2.6.0.sql upgrade script
  • Makefile: add the upgrade script to DATA

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Changes

Version upgrade

Layer / File(s) Summary
Package version 2.6.0
snowflake.control, snowflake--2.5.0--2.6.0.sql, Makefile
The extension default version changes to 2.6.0, and the guarded upgrade script is added to the packaged SQL files.

Poem

I’m a rabbit with a versioned nose,
Hopping where the upgrade script goes.
“Two-point-six!” I cheer,
The new path is clear,
Packaged neatly in rows.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the main change by stating the extension version bump to 2.6.0.
Description check ✅ Passed The description is directly related and summarizes the metadata bump, new upgrade script, and Makefile update.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch SPOCK-625-snowflake-extension-not-bumped

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

codacy-production Bot commented Jul 20, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 1 high

Results:
1 new issue

Category Results
Compatibility 1 high

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
test/t/snowflake_version.py (1)

63-65: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Update misleading error message.

The error message explicitly mentions (no snowflake--{EXPECTED_VERSION}.sql), which implies a base installation script is required. However, the Makefile does not include a base snowflake--2.6.0.sql script—PostgreSQL also considers a version offered if it can be reached by chaining upgrade scripts (e.g., snowflake--2.5.0--2.6.0.sql). Consider updating the message to avoid misdirecting developers if the test ever fails.

💡 Proposed fix
-    failures.append(
-        f"'{EXPECTED_VERSION}' is not an offered version (no snowflake--{EXPECTED_VERSION}.sql); "
-        f"offered: {offered}")
+    failures.append(
+        f"'{EXPECTED_VERSION}' is not an offered version (missing base or upgrade script); "
+        f"offered: {offered}")
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/t/snowflake_version.py` around lines 63 - 65, Update the failure message
in the version-offering check that appends to failures so it no longer claims a
base snowflake--EXPECTED_VERSION.sql script is required. Describe the version as
unavailable among the offered or reachable upgrade versions, while preserving
the offered versions output.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@test/t/snowflake_version.py`:
- Around line 63-65: Update the failure message in the version-offering check
that appends to failures so it no longer claims a base
snowflake--EXPECTED_VERSION.sql script is required. Describe the version as
unavailable among the offered or reachable upgrade versions, while preserving
the offered versions output.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 071a0fad-9739-4141-a0df-9e766bb403da

📥 Commits

Reviewing files that changed from the base of the PR and between fce5e57 and 944e56e.

📒 Files selected for processing (5)
  • Makefile
  • snowflake--2.5.0--2.6.0.sql
  • snowflake.control
  • test/schedule_files/script_file
  • test/t/snowflake_version.py

Comment thread snowflake--2.5.0--2.6.0.sql Outdated
Comment thread test/schedule_files/script_file Outdated
Comment thread test/t/snowflake_version.py Outdated
zaidshabbir25 and others added 2 commits July 21, 2026 11:26
The v2.6.0 tag was cut without bumping the extension version metadata:
snowflake.control still declared default_version = '2.5.0' and no
2.6.0 SQL script existed, so the extension installed and reported
itself as 2.5.0 even when built from the v2.6.0 tag.

- snowflake.control: default_version 2.5.0 -> 2.6.0
- add snowflake--2.5.0--2.6.0.sql upgrade script (2.6.0 is the
  Postgres 19 port, a C/build change with no catalog changes)
- Makefile: add the upgrade script to DATA
- add test/t/snowflake_version.py regression guarding the version
  metadata, registered in the script_file schedule

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@mason-sharp
mason-sharp force-pushed the SPOCK-625-snowflake-extension-not-bumped branch from 944e56e to 2b79322 Compare July 21, 2026 18:28
@mason-sharp
mason-sharp merged commit f888a97 into main Jul 21, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants