Ignore invalid download paths instead of panicking - #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
getDataForPathpanics when a download path contains no.separator. Every caller reaches it fromDownload, whichSettings.Handleruns as a goroutine, so an unrecognizedMapdInputType_downloadvalue does not fail the download — it takes down the process. mapd runs that download alongside the 50 ms loop publishing speed-limit and curve-speed output, so a single malformed command string from a fork ends live driving output until the daemon is restarted.The path string is fork-supplied (
docs/inputs.md), and the failure needs nothing exotic:"ohio"instead of"north-america.ohio"is enough.A well-formed path naming a region that does not exist already behaves harmlessly — the menu lookup misses and returns a zero
LocationData, so the download resolves to zero files. This change gives the malformed case that same outcome and logs why, rather than treating it as unrecoverable.Behavior
68813e05north-america.ohioohio(no separator)""north-america.not-a-placeValidation
"ohio","", and"."— both directly and throughcountTotalFiles, the call pathDownloadtakes before any download begins — and confirmed Head returns a zero value with a warning on all three while a populated menu entry still resolves to its real record.go build ./...,go vet ./..., andgo test ./...pass on Head.Compatibility
getDataForPathis unexported and its callers are untouched.getDataForPathbyte-identical, so the two apply cleanly in either merge order.