Skip to content

minor refactor of get limit #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peterxcli wants to merge 1 commit into
base: feat/limited-distinct
Choose a base branch
from
Open

minor refactor of get limit #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 19 additions & 28 deletions src/execution/physical_plan/plan_limit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,23 @@

namespace duckdb {

bool UseBatchLimit(PhysicalOperator &child_node, BoundLimitNode &limit_val, BoundLimitNode &offset_val) {
static optional_idx GetLimit(const BoundLimitNode &limit_val, const BoundLimitNode &offset_val) {
if (limit_val.Type() != LimitNodeType::CONSTANT_VALUE) {
return optional_idx();
}
if (offset_val.Type() != LimitNodeType::CONSTANT_VALUE && offset_val.Type() != LimitNodeType::UNSET) {
return optional_idx();
}

idx_t total = limit_val.GetConstantValue();
if (offset_val.Type() == LimitNodeType::CONSTANT_VALUE &&
!TryAddOperator::Operation(total, offset_val.GetConstantValue(), total)) {
return optional_idx();
}
return optional_idx(total);
}

bool UseBatchLimit(PhysicalOperator &child_node, const BoundLimitNode &limit_val, const BoundLimitNode &offset_val) {
#ifdef DUCKDB_ALTERNATIVE_VERIFY
return true;
#else
Expand All @@ -36,36 +52,11 @@ bool UseBatchLimit(PhysicalOperator &child_node, BoundLimitNode &limit_val, Boun
// as the batch limit materializes this many rows PER thread
static constexpr const idx_t BATCH_LIMIT_THRESHOLD = 10000;

if (limit_val.Type() != LimitNodeType::CONSTANT_VALUE) {
return false;
}
if (offset_val.Type() == LimitNodeType::EXPRESSION_VALUE) {
return false;
}
idx_t total_offset = limit_val.GetConstantValue();
if (offset_val.Type() == LimitNodeType::CONSTANT_VALUE) {
total_offset += offset_val.GetConstantValue();
}
return total_offset <= BATCH_LIMIT_THRESHOLD;
auto total_limit = GetLimit(limit_val, offset_val);
return total_limit.IsValid() && total_limit.GetIndex() <= BATCH_LIMIT_THRESHOLD;
#endif
}

static optional_idx GetLimit(BoundLimitNode &limit_val, BoundLimitNode &offset_val) {
if (limit_val.Type() != LimitNodeType::CONSTANT_VALUE) {
return optional_idx();
}
if (offset_val.Type() != LimitNodeType::CONSTANT_VALUE && offset_val.Type() != LimitNodeType::UNSET) {
return optional_idx();
}

idx_t total = limit_val.GetConstantValue();
if (offset_val.Type() == LimitNodeType::CONSTANT_VALUE &&
!TryAddOperator::Operation(total, offset_val.GetConstantValue(), total)) {
return optional_idx();
}
return optional_idx(total);
}

static bool CanUseLimitedDistinct(const PhysicalHashAggregate &hash_aggregate) {
if (hash_aggregate.grouped_aggregate_data.groups.empty()) {
return false;
Expand Down
Loading