Return consistent tangent in Penalty and Lagrange constraints - #118
Open
gaaraujo wants to merge 1 commit into
Open
Return consistent tangent in Penalty and Lagrange constraints#118gaaraujo wants to merge 1 commit into
gaaraujo wants to merge 1 commit into
Conversation
Route getTangent/getResidual through formEleTangent/formEleResidual so constraint contributions respect integrator factors (e.g. mass-only eigen assembly and Newmark c1). Adapted from OpenSees #1781 using override/final instead of bare virtual.
gaaraujo
force-pushed
the
fix/penalty-lagrange-tangent
branch
from
August 9, 2026 23:46
1d1b25c to
d717736
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
getTangentin the Penalty and Lagrange FE elements bypassed the integrator. As a result:formM→getTangent→addM, or in certain explicit integrators that assemble only mass on the left-hand side.This PR routes the Penalty and Lagrange constraint FE tangents through the integrator and also implements previously missing methods, including
getK_ForceandgetTangForce.