Added onDispose Functionality and Modified deps Type to Array in useEffect - #13
Closed
psyrenpark wants to merge 1 commit into
Closed
Added onDispose Functionality and Modified deps Type to Array in useEffect#13psyrenpark wants to merge 1 commit into
psyrenpark wants to merge 1 commit into
Conversation
Hello, I have made some modifications while using it. I would appreciate it if you could review them.
|
In fact, every timeif you pass Of course, if you insist on doing this through a hook, then your deps should be |
Owner
|
I'm not accepting this PR in favor of ComposeHooks and in v2 of this library, this module is removed (See #16). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello ~,
I needed an onDispose functionality within useEffect, so I've added it. Additionally, I have changed the type of deps to an array.
I would appreciate it if you could review them.