Fix Release #13: Windows SSH agent + macOS DMG EULA attach - #18
Merged
Conversation
AgentClient::connect_env is Unix-only, so Windows release builds failed after the SSH tunnel landed; connect via OpenSSH named pipe or Pageant instead. Also feed Agree to hdiutil when verifying DMGs that embed the packager license-file as an EULA. Co-authored-by: Pavitra Golchha <hello@pavi2410.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
based | 4521d23 | Commit Preview URL Branch Preview URL |
Aug 19 2026, 08:23 PM |
pavi2410
marked this pull request as ready for review
August 19, 2026 17:13
Boxing the agent stream dropped the 'static bound russh's Signer impl needs and caused higher-ranked lifetime errors in Tokio::spawn_result on the Postgres open/test paths. Keep concrete Unix/Windows agent types. Co-authored-by: Pavitra Golchha <hello@pavi2410.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release run #13 failed on two platforms (Linux succeeded). This PR fixes both root causes, plus a Clippy HRTB regression from the first Windows agent attempt.
Windows — compile error in
based-sshAgentClient::connect_env()is Unix-only (SSH_AUTH_SOCK). CI does not build Windows; the release matrix does.Fix: connect via
\\.\pipe\openssh-ssh-agent, then fall back to Pageant — using concrete stream types (no.dynamic()).macOS —
hdiutil: attach canceledPackager
license-filebecomes a DMG EULA (--eula). Non-interactivehdiutil attachprints the license and cancels.Fix: feed
Yon stdin when attaching in the verify step.Clippy on this PR
The first Windows fix boxed the agent with
.dynamic(), which dropped the'staticbound russh’sSignerimpl needs and surfaced ashigher-ranked lifetime erroratTokio::spawn_resultinapps/desktop/src/postgres/mod.rs. Follow-up commit keeps concrete agent types per platform.Test plan
cargo test -p based-sshcargo clippy --workspace --all-targetsmainafter merge