This repository was archived by the owner on Aug 3, 2026. It is now read-only.
fix: replace vacuum delay with epoch grace period - #184
Closed
pathscale wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Superseded by #187, which consolidated and merged the backend-selection and publication hardening work after the combined review and validation rounds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EmptyLinkRegistry::pop_maxsignatureThis closes the in-flight free-link reuse race that the old sleep attempted to cover. It does not claim a general reader epoch across index lookup and row deserialization; that broader read-vs-vacuum validation remains separate work.
Performance
Added
simple_delete_insert_reuse, which measures the delete/insert churn path where the epoch atomics execute. Five alternating copied-binary pairs (30 samples, 0.5 s warm-up, 1 s measurement) produced paired changes of:Median change was approximately +0.0%, with no consistent regression, so this is not feature-gated. Vacuum also no longer pays the unconditional 100 ms delay.
Verification
cargo test(117 unit; 324 integration passed, 5 existing ignores)cargo clippy --all-targets -- -D warningscargo fmt --check