This repository was archived by the owner on Aug 3, 2026. It is now read-only.
feat: gate synchronized page access - #183
Closed
pathscale wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Superseded by #187, which consolidated and merged the backend-selection and publication hardening work after the combined review and validation rounds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
safe-concurrent-readscorrectness modePerformance
Five alternating copied-binary benchmark pairs (30 samples, 0.5 s warm-up, 1 s measurement) found:
simple_select_by_pk: +1.2% to +2.3%, median +1.5%simple_update: -0.9% to +1.0%, median +0.2% (noise-sized)The enabled mode also intentionally serializes page mutations, so write-heavy concurrent workloads can see a larger throughput cost. The feature is therefore off by default.
Verification
cargo testcargo test --features safe-concurrent-readscargo clippy --all-targets -- -D warningscargo clippy --all-targets --features safe-concurrent-reads -- -D warningscargo fmt --checkThe feature-gated regression test pauses publication after one field changes and verifies that a concurrent reader cannot pass the barrier or observe the incomplete row; after unghosting, it sees the complete row.