docs(readme): stop documenting a subpath that no longer ships - #244
Merged
Conversation
useVirtualRows went out with TanStack solid-virtual, and the primitives/ virtualizer directory went with it, but the subpath-exports example still imported from it. The release job's package check caught it against the tarball, which is what that gate is for: a README naming a module that does not exist would have shipped to npm unpublishable. Swapped for hooks/table, which ships and makes the same point about narrowing an import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Release run for 2.6.0 failed its package check:
useVirtualRowswent out with TanStacksolid-virtualand theprimitives/virtualizerdirectory went with it, but the subpath-exports example in the README still imported from it. The gate caught it against the actual tarball, which is exactly its job, since a README naming a nonexistent module would have shipped to npm unpublishable.Swapped for
hooks/table, which ships and makes the same point about narrowing an import.bun run check:package: passes, 926 files, all exports and README imports resolve.Note CI itself was green on
890e39a; only the Release workflow failed, which is why npm still serves 2.5.0.🤖 Generated with Claude Code