fix: consolidate release hardening and torn-store refusal - #47
Merged
Conversation
pathscale
force-pushed
the
fix/pr46-review-findings
branch
from
August 4, 2026 21:39
19bffac to
6262ab7
Compare
Linearize PR #47 on the current master while preserving its exact reviewed tree. Includes release-hardening regression coverage, beta.4 metadata, and the accepted best-effort persistence durability boundary with typed torn-store rejection.
pathscale
force-pushed
the
fix/pr46-review-findings
branch
from
August 4, 2026 22:22
c680621 to
54e1e11
Compare
Merged
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the correctness and release-hardening work after PR #46:
WorkTablesIndex =0.0.5/data_bucket =0.5.2dependency chain;Issue #41 durability boundary
Existing persisted stores now receive a startup-only validation pass before a table is returned:
PersistenceLoadErrortype.The durability guarantee matrix and supported restore/rebuild procedure are documented in
docs/persistence-durability.mdand linked prominently from the README. This does not claim crash-atomic durability:SIGKILLor power loss may lose acknowledged writes, and WorkTable does not provide an in-place salvage path.The validation is proportional to rows × indexes and runs only on existing-store startup. It adds no branch, lock, or scan to steady-state insert/select/update/delete paths.
Review notes / known boundary
tests/worktable/update_in_place_unsized.rs::same_length_update_stays_in_placeremains ignored and explicitly documents the known unsized-row in-place update performance blocker. This PR does not claim that blocker is resolved.docs/pr46-review-findings.md.Verification
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo test --workspace --all-targetscargo test --workspace --all-targets --all-featuresAll commands pass locally on macOS ARM64.