Skip to content

Fix legacy site scene loading#544

Merged
wass08 merged 1 commit into
mainfrom
fix/legacy-site-scene-loading
Jul 24, 2026
Merged

Fix legacy site scene loading#544
wass08 merged 1 commit into
mainfrom
fix/legacy-site-scene-loading

Conversation

@wass08

@wass08 wass08 commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • preserve embedded legacy site children until the existing scene migration flattens them
  • prevent contentful legacy building subtrees from being pruned as unreachable
  • cover the healer and full setScene path with regression tests

Test plan

  • 760 core tests pass
  • Editor monorepo build passes
  • Production Casa model loads locally with 84/84 nodes
  • Local bake route renders a 1920×1080 thumbnail with zero unreachable nodes

Note

Low Risk
Narrow load-time change in scene graph healing for legacy site children; other child cleaning behavior is unchanged and covered by tests.

Overview
Fixes legacy scene loading where old site nodes stored full child objects in children instead of id strings. healSceneNodes used to treat those objects like invalid entries and drop them, which could disconnect or prune entire building subtrees before migration ran.

heal-scene-graph now keeps embedded objects on site nodes (still strips null and dedupes by child id) so the existing migrateNodes / setScene path can flatten them to string ids. Comments and strippedChildRefs wording are tightened to reflect “invalid” non-string refs only.

Regression coverage: heal-scene-graph.test for the healer behavior and use-scene-site-child-migration.test for a full embedded-site → flat graph load.

Reviewed by Cursor Bugbot for commit 1c2bd68. Bugbot is set up for automated code reviews on this repo. Configure here.

@wass08
wass08 merged commit f0985df into main Jul 24, 2026
3 checks passed
@wass08
wass08 deleted the fix/legacy-site-scene-loading branch July 24, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant