Fix legacy site scene loading#544
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Note
Low Risk
Narrow load-time change in scene graph healing for legacy site children; other child cleaning behavior is unchanged and covered by tests.
Overview
Fixes legacy scene loading where old
sitenodes stored full child objects inchildreninstead of id strings.healSceneNodesused to treat those objects like invalid entries and drop them, which could disconnect or prune entire building subtrees before migration ran.heal-scene-graphnow keeps embedded objects onsitenodes (still stripsnulland dedupes by child id) so the existingmigrateNodes/setScenepath can flatten them to string ids. Comments andstrippedChildRefswording are tightened to reflect “invalid” non-string refs only.Regression coverage:
heal-scene-graph.testfor the healer behavior anduse-scene-site-child-migration.testfor a full embedded-site → flat graph load.Reviewed by Cursor Bugbot for commit 1c2bd68. Bugbot is set up for automated code reviews on this repo. Configure here.