Improve editor placement and selection workflows#543
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 4 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9f220c8. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Verification
bun test packages/editor/src/lib/scene-clipboard.test.ts packages/editor/src/lib/selection-routing.test.ts packages/editor/src/components/editor-2d/renderers/floorplan-registry-layer.test.ts packages/nodes/src/spawn/__tests__/parity.test.ts(43 pass)bun run check-typesbun run buildgit diff --checkNote
Medium Risk
Clipboard and scene-graph delete/paste paths touch materials, hosted openings, and interaction scope; floorplan event routing changes selection timing around door/window placement.
Overview
Cross-tab copy/cut/paste now serializes scene nodes and referenced custom materials to the system clipboard (
pascal.scene-nodes), waits on in-flight writes before paste, and places pasted content with click-to-carry (cursor-centered group move or door/window re-host flow). Cut mirrors copy roots then deletes them; group carry cancels on clipboard chords and handles paste material cleanup on escape.Bulk delete swaps
window.confirmfor an in-editorDeleteConfirmationDialog(Zustand store); keyboard shortcuts are suppressed while it is open.selection:canvas-node-clickis emitted from 2D floorplan and 3D selection paths after a user click resolves to a single target—intended for hosts syncing catalogs without reacting to programmatic selection.Floorplan opening placement no longer disables registry handlers at render time;
isFloorplanOpeningPlacementStategates pointer/click at event time so post-placement selection is not lost in a dead zone after commit.Spawn placement uses the real
SpawnPreviewmodel (ghost) with R/T rotation before commit, matching tool hints and parity tests.Reviewed by Cursor Bugbot for commit e501ddb. Bugbot is set up for automated code reviews on this repo. Configure here.