fix(cli): derive storage-deposit floor from chain tokenDecimals - #268
Open
itsnevu wants to merge 4 commits into
Open
fix(cli): derive storage-deposit floor from chain tokenDecimals#268itsnevu wants to merge 4 commits into
itsnevu wants to merge 4 commits into
Conversation
itsnevu
changed the title
sphamjoli
self-requested a review
August 22, 2026 21:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes paritytech/dotns#226.
The storage-deposit floor was hardcoded to 2_000_000_000_000n. At 10 decimals that's 200 tokens, not the 2 the comment claims, so the limit ends up 100x too high and the dry-run branch above it never really applies.
This derives the floor from the chain's tokenDecimals (2 * 10^decimals) instead, falling back to DEFAULT_NATIVE_TOKEN_DECIMALS, and passes the real decimals into ReviveClientWrapper.
Ran lint, format, typecheck and the unit tests (301/301) in packages/cli, all green.