feat(httproutes): support per-route annotations in httpRoutes - #444
Conversation
Allow consumers to set arbitrary annotations on individual HTTPRoute resources via the httpRoutes[].annotations field in values. Previously only the external-dns annotation was emitted; all other per-route annotations were silently ignored. Closes INF-4027
There was a problem hiding this comment.
Pull request overview
This PR enhances the shared Helm library chart so that each generated Gateway API HTTPRoute can include arbitrary, user-defined annotations via httpRoutes[].annotations, instead of only emitting the external-dns hostname annotation.
Changes:
- Extend
common’sHTTPRoutetemplate to render per-route annotations. - Bump
commonchart version to publish the library change. - Bump
monolithchart version to publish the consumer-facing change for that chart.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| parcellab/monolith/Chart.yaml | Bumps monolith chart version to release the updated behavior. |
| parcellab/common/templates/_httproutes.tpl | Adds rendering of httpRoutes[].annotations into each HTTPRoute’s metadata. |
| parcellab/common/Chart.yaml | Bumps common library chart version to release the template change. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4597d2f45d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Allow consumers to set arbitrary annotations on individual HTTPRoute resources via the httpRoutes[].annotations field in values. Previously only the external-dns annotation was emitted; all other per-route annotations were silently ignored.
INF-4027