FIX: allow turning off valves when leaving home with window open

[andreipoenaru]

Without this change, specifying an input_window_open_temperature (!= 0) prevents the automation from turning off the termostats when the window is open, even if the conditions for turning off the thermostats are otherwise met (e.g., people left home).

[andreipoenaru]

@panhans Does this patch look good to you?

[panhans]

Hey, I just released a new version of the blueprints with some major changes. Could you describe in steps what to do to reproduce the behaviour? Maybe the new version resolved the problem but I want to to test this in my testing environment. Sry, for the late reply.

[andreipoenaru]

I've rebased the proposed changes onto the latest version of the automation (i.e., 5.5.0): as far as I can tell the issue would still reproduce.

The scenario involves:

1. setting up an automation that (a) changes the target thermostat temperature when the window is open and (b) turns off the thermostat when nobody is home
2. opening the window
3. all the people leaving home

Expected behavior: the thermostat is turned off (since nobody is home)
Observed behavior: the thermostat is on (with the temperature for open window)

Here is the full automation config (based on version 5.5.0 of the blueprint):

alias: 🔥 Control HEATING in the RESTROOM WITH SHOWER
use_blueprint:
  path: panhans/advanced_heating_control.yaml
  input:
    input_trvs:
      - climate.restroom_with_shower_thermostat_local
    input_hvac_mode_comfort: heat
    input_hvac_mode_eco: "off"
    input_temperature_comfort_static: 23
    input_temperature_eco_static: 21
    input_persons:
      - person.p1
      - person.p2
    input_people_entering_home_duration:
      hours: 0
      minutes: 0
      seconds: 0
    input_people_leaving_home_duration:
      hours: 0
      minutes: 2
      seconds: 0
    input_mode_guest: binary_sensor.climate_guest_mode
    input_windows:
      - binary_sensor.restroom_with_shower_window_door
    input_windows_reaction_time_open:
      hours: 0
      minutes: 0
      seconds: 15
    input_windows_reaction_time_close:
      hours: 0
      minutes: 2
      seconds: 0
    input_mode_winter: input_boolean.restroom_with_shower_thermostat_off_set_externally
    input_invert_winter_mode_value: true
    input_temperature_comfort: input_number.heating_temperature_in_the_restroom_with_shower
    input_physical_change: false
    input_window_legacy_restore: true
    input_window_open_temperature: 5
    input_startup_delay:
      hours: 0
      minutes: 2
      seconds: 30

[andreipoenaru]

@panhans Did you manage to take a look?