Remove provenance metadata fields from passkey storage - #109
Merged
Conversation
Remove createdByCallerType, createdByPackage, createdByCertificateDigest, and verifiedOrigin fields from PasskeyCredential and StoredCredential. These fields stored information about which app/browser created the passkey (e.g., org.mozilla.fenix), but this metadata is not needed for WebAuthn ceremonies and adds unnecessary complexity to the storage format. Old credentials with these fields will continue to work - the extra CBOR keys are safely ignored during deserialization. Deleted StoredCredentialBindingMetadataTest.kt as it tested the removed functionality. Fixes compatibility issues with tools like soft-fido2 that expect strict WebAuthn-compliant CBOR encoding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove provenance metadata fields that tracked which app/browser created each passkey. These fields are not required for WebAuthn ceremonies and add unnecessary complexity to the CBOR storage format.
Changes
Removed fields from PasskeyCredential and StoredCredential:
createdByCallerType(NATIVE_APP vs PRIVILEGED_BROWSER)createdByPackage(e.g., "org.mozilla.fenix", "com.android.chrome")createdByCertificateDigest(signing certificate hash)verifiedOrigin(web origin for browser callers)Files modified:
PasskeyCredential.kt- removed fields, equals(), hashCode(), CallerType importStoredCredential.kt- removed fields, CBOR serialization/deserialization, equals(), hashCode()AppPasskeyProviderActivity.kt- removed .copy() call that populated these fieldsStoredCredentialBindingMetadataTest.kt(tested removed functionality)Backward Compatibility
Old credentials with these fields will continue to work. The extra CBOR keys are safely ignored during deserialization since the fields are no longer part of the data model.
Testing
All
passkeys:coretests pass.Related
This change improves compatibility with tools like soft-fido2 that expect strict WebAuthn-compliant CBOR encoding without extra metadata fields.