Conversation
ljubomirm
reviewed
Jun 16, 2025
| spec.files = Dir.glob("lib/**/*") + %w[LICENSE.txt README.md] | ||
| spec.require_paths = ["lib"] | ||
| spec.required_ruby_version = ">= 2.7" | ||
| spec.required_ruby_version = ">= 3.1" |
Owner
Author
There was a problem hiding this comment.
Though the library can still be used with older Rubies (without data); we have a note in the Readme
ljubomirm
reviewed
Jun 16, 2025
| class Engine < ::Rails::Engine | ||
| config.downstream = Downstream.config | ||
|
|
||
| ::GlobalID::Locator.use "downstream" do |gid| |
There was a problem hiding this comment.
Feels like a better place for this code.
ljubomirm
reviewed
Jun 16, 2025
| end | ||
| end | ||
|
|
||
| def define(*fields, &) |
There was a problem hiding this comment.
attributes and and define feel to me like different strategies to be applied or configured on the Event class.
I do like the new public method, but I think the public interface with this definition doesn't clearly state what's going on, that one variant is mutable and the other immutable. Perhaps the strategy could be defined through an attributes parameter, like immutable: true.
palkan
marked this pull request as ready for review
August 20, 2025 22:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR tracks the changes for v2.
What's inside
Downstream::SubscriberclassChecklist: