Mark unsupported VPD commands as Illegal - #38
Merged
Conversation
Based on some testing I did on a Cosmo in the lab, there are a variety
of VPD-related `MFR_$whatever` and `IC_DEVICE_{ID, REV}` commands that
various devices dislike. See [this comment][1] for details.
To prevent them from NACKing us and setting `STATUS_CML` a bunch, and to
better support the codegen changes I'm working on in
oxidecomputer/hubris#2650, this commit updates the config files for
those devices to mark the commands they find distasteful as `Illegal`.
[1]:
oxidecomputer/hubris#2650 (comment)
jamesmunns
approved these changes
Aug 28, 2026
jamesmunns
left a comment
jamesmunns
left a comment
Contributor
There was a problem hiding this comment.
Oooooooh, this feels illegal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on some testing I did on a Cosmo in the lab, there are a variety of VPD-related
MFR_$whateverandIC_DEVICE_{ID, REV}commands that various devices dislike. See this comment for details.To prevent them from NACKing us and setting
STATUS_CMLa bunch, and to better support the codegen changes I'm working on in oxidecomputer/hubris#2650, this commit updates the config files for those devices to mark the commands they find distasteful asIllegal.