support enable_jumbo_frames option in instance from-image subcommand - #1525
Merged
Conversation
Contributor
Author
|
Testing notes |
Co-authored-by: Adam Leventhal <ahl@oxide.computer>
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Aug 29, 2026
Closes #9359, closes #4942, closes #7649, and redoes #9871. - `silo_user_list` and `silo_user_view` said "built-in (system) users", but they are for regular silo users (#9359) - Clarify that the audit log `start_time` and `end_time` params filter on `time_completed` (redo of #9871) - Add missing doc comment on `SiloCreate.discoverable` and reword the matching one on the `Silo` view (#4942) - Reword `AffinityPolicy` variant docs to avoid the ambiguous "affinity request": constraints apply when an instance starts, and with `fail` the start request errors and the instance remains stopped (#7649) Also say "network interface" instead of "OPTE" in the jumbo frames doc comments — noticed in the discussion on [oxidecomputer/oxide.rs#1525](oxidecomputer/oxide.rs#1525), where the OPTE wording had been copied into the CLI. "Primary network interface" is accurate: the jumbo MTU is applied only to the primary NIC's OPTE port, and only when both the fleet flag and the instance bit are set. https://github.com/oxidecomputer/omicron/blob/bc1e632df4f9f8b18de7f78bc1602071fca75536/nexus/src/app/instance.rs#L2923-L2935
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch up on the support for a new instance attribute known as
enable_jumbo_frames. The option is uncommon (use of it requires upstream network support and fleet-admin explicitly enabling the option) but having the CLI support will simplify internal test automation.