Save generated system version in a file - #79
Open
david-crespo wants to merge 1 commit into
Open
Conversation
david-crespo
force-pushed
the
save-system-version
branch
from
July 6, 2026 19:43
e4296a2 to
b3a1c66
Compare
Author
|
@smklein since you have written the most lines in this repo, would appreciate a glance to see if this is a reasonable idea or if you'd prefer to do it another way. |
david-crespo
marked this pull request as ready for review
July 13, 2026 22:49
Author
|
Confirmed in oxidecomputer/omicron#10839 that this works for the purpose. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft having to do with logic I'm contemplating and attempting to justify in RFD 708 and oxidecomputer/omicron#10250 to display the full generated system version string rather than just the
20.2.0"semver core" part.Currently this puts the file in all zones because adding logic to aim it at Nexus in particular seems like overkill, and the file isn't hurting anything. But that could easily be changed.