fix: [OCISDEV-1045] Show vault-shared mountpoints in the vault drive list - #12644
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
2403905
force-pushed
the
fix/OCISDEV-1045
branch
from
July 27, 2026 07:20
9107374 to
ab170c6
Compare
2403905
force-pushed
the
fix/OCISDEV-1045
branch
from
July 27, 2026 08:48
ab170c6 to
fe87362
Compare
2403905
enabled auto-merge (squash)
July 27, 2026 10:35
LukasHirt
approved these changes
Jul 27, 2026
mzner
self-requested a review
July 27, 2026 11:27
mzner
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related PR owncloud/reva#666
Shares of vault resources are mountpoints hosted on the shares storage provider
that grant into the vault storage provider. When listing spaces with the vault
storage_id, the storage registry skipped the shares provider entirely, so thevault share mountpoint was missing from the vault drive list while still showing
up in the regular drive list.
The registry now also queries the shares provider when the vault storage id is
requested and segregates share mountpoints by their
grantStorageID, so a vaultshare only appears in the vault drive list and a regular share only in the
regular one.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: