Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/request-log-field-names.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"template-node-express": minor
---

Use clearer nested req/res field names in request logging (aligned with pino-http style).
23 changes: 14 additions & 9 deletions src/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export const initApp = async (

const requestId = req.headers['x-request-id']?.[0] || randomUUID();

const l = logger.child({ requestId });
const l = logger.child({ req: { id: requestId } });

let bytesRead = 0;
req.on('data', (chunk: Buffer) => {
Expand All @@ -88,14 +88,19 @@ export const initApp = async (
res.on('finish', () => {
l.info(
{
duration: new Date().getTime() - start,
method: req.method,
path: req.path,
status: res.statusCode,
ua: req.headers['user-agent'],
ip: getClientIp(req),
br: bytesRead,
bw: bytesWritten,
req: {
id: requestId,
method: req.method,
path: req.path,
userAgent: req.headers['user-agent'],
ip: getClientIp(req),
bytesRead,
},
res: {
statusCode: res.statusCode,
bytesWritten,
},
responseTime: new Date().getTime() - start,
},
'Request handled'
);
Expand Down
Loading