Implement FusedIterator for our iterators. - #116
Open
ChrisJr404 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16.
This implements
FusedIteratorfor all the collection iterators.FusedIteratorhas been stable for a long time now, so the "when it stabilizes" caveat no longer applies.Once each of the base iterators (
IterPtr, the queue'sLazilyReversedListIter, and the red-black tree'sRangeIterPtr) returnsNoneit keeps returningNone, so the marker is sound. The publicIter,IterKeys,IterValuesandRangeItertypes arecore::iter::Mapwrappers over those base iterators, so they pick upFusedIteratorautomatically once the base ones have it.I added a small "keeps returning None" test per collection, plus
assert_impl_all!checks on the public iterator types so the trait stays wired up.