Add pop_first and pop_last to RedBlackTreeSet - #115
Open
ChrisJr404 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
pop_first/pop_last(and their_mutcounterparts) toRedBlackTreeSet, closing #35, so removing the smallest or largest element and getting it back can be done in one call instead of afirst()/remove_mut()dance.The immutable variants return the new set alongside the popped value, and the
_mutvariants remove in place and hand back the value, matching theSome(value)/Noneshape you'd expect fromBTreeSet::pop_first. Everything is expressed in terms of the existingfirst/last/remove/remove_mutmethods, so there are no changes to the tree internals; the extraT: Clonebound only applies to these methods since the element is returned by value. Tests cover the empty case, repeated popping down to empty, and that the immutable form leaves the original set untouched.