Skip to content

fix(orgs): enforce root-cause-first org validation - #547

Open
beruro wants to merge 1 commit into
developfrom
junyu/root-cause-org-validation
Open

fix(orgs): enforce root-cause-first org validation#547
beruro wants to merge 1 commit into
developfrom
junyu/root-cause-org-validation

Conversation

@beruro

@beruro beruro commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Problem

URL-shaped invite values can reach the authoritative local organization write path and be persisted as real project_orgs rows. Hiding those rows in the UI would leave invalid domain data intact.

Solution

  • Reject URL-shaped organization names at the persistence write boundary.
  • Add regression coverage for orgii, HTTP, and SSH URLs.
  • Record the root-cause-first invariant in the repository’s agent guidance so future fixes target the producing boundary.
  • Validation: project-management tests/check/clippy, scoped rustfmt, diff check, and guidance parity checks.

Potential risks

  • Validation must not reject legitimate non-URL organization names.
  • Historical polluted rows require separate, narrowly confirmed cleanup; this PR does not perform broad data deletion.
  • The repository-guidance edits are intentional policy documentation for the same invariant, not runtime behavior.

@beruro
beruro force-pushed the junyu/root-cause-org-validation branch 3 times, most recently from 3dd5700 to aafcdd1 Compare July 30, 2026 08:03
@beruro
beruro force-pushed the junyu/root-cause-org-validation branch from aafcdd1 to d955f61 Compare July 30, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant