Skip to content

feat(team-inbox): add unified inbox with lifecycle fixes - #530

Closed
beruro wants to merge 0 commit into
junyu/rpc-performance-closurefrom
feat/team-inbox-lifecycle-fixed
Closed

feat(team-inbox): add unified inbox with lifecycle fixes#530
beruro wants to merge 0 commit into
junyu/rpc-performance-closurefrom
feat/team-inbox-lifecycle-fixed

Conversation

@beruro

@beruro beruro commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • reintroduce the viewer-scoped Team Inbox after the original merge was reverted
  • merge local Work Item assignments with validated managed-cloud comment mentions
  • add the master/detail surface, unread/read actions, filters, search, pagination, canonical navigation, and singleton Chat Panel/Sidebar integration
  • include the follow-up React lifecycle fixes: pure recency grouping, request-keyed body loading, stale-response rejection, and stable realtime teardown capture

Validation

  • focused Vitest suite: 87 tests passed
  • tsc --noEmit
  • full pnpm run lint
  • cargo test --manifest-path src-tauri/Cargo.toml -p project_management team_inbox --no-fail-fast: 12 passed
  • cargo check --manifest-path src-tauri/Cargo.toml -p org2
  • git diff --check

Audits

  • Architecture: all 10 layers covered; viewer IDs, tagged DTOs, command parity, and schema initialization verified
  • Frontend UI (feature): 7 fixes, 4 keep with reason, 0 abstraction candidates
  • Frontend UI (lifecycle follow-up): 2 fixes, 4 keep with reason, 0 abstraction candidates
  • Performance: PASS. No polling; refresh remains demand/signal-driven, concurrent reads are guarded, stale loads are rejected, subscriptions/timers have teardown, and cloud receipts remain capped at 1,000

Supersedes the reverted #521 and obsolete follow-up #529.

@beruro
beruro changed the base branch from develop to junyu/rpc-performance-closure July 27, 2026 05:14
@beruro

beruro commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

Restacked onto #512 to remove the duplicated Team Inbox implementation. This PR now contains only the 13-file lifecycle/realtime follow-up delta. Merge #512 first, then retarget this PR to develop so branch-filtered CI runs.

@beruro
beruro force-pushed the junyu/rpc-performance-closure branch 2 times, most recently from 08c6161 to f2c5742 Compare July 29, 2026 05:20
@beruro
beruro force-pushed the feat/team-inbox-lifecycle-fixed branch from 3a018b6 to 1c0b781 Compare July 30, 2026 05:16
@beruro
beruro changed the base branch from junyu/rpc-performance-closure to develop July 30, 2026 05:16
@beruro beruro changed the title feat(team-inbox): add unified inbox with lifecycle fixes fix(team-inbox): defer recency grouping clock until data loads Jul 30, 2026
@beruro
beruro force-pushed the feat/team-inbox-lifecycle-fixed branch from 1c0b781 to 3a018b6 Compare July 30, 2026 05:20
@beruro beruro changed the title fix(team-inbox): defer recency grouping clock until data loads feat(team-inbox): add unified inbox with lifecycle fixes Jul 30, 2026
@beruro
beruro changed the base branch from develop to junyu/rpc-performance-closure July 30, 2026 05:20
beruro added a commit that referenced this pull request Jul 30, 2026
@ahanafish

Copy link
Copy Markdown

Superseded after the PR stack cleanup. #512 is already merged into develop, Team Inbox lifecycle work landed through #558, and the remaining CLI/session/diagnostics/resource-lifecycle changes now live in the rebuilt focused PRs #562-#567. The pre-cleanup head is preserved at backup/pr-530-pre-rebuild-20260730.

@beruro
beruro force-pushed the junyu/rpc-performance-closure branch from c42f777 to cb96c41 Compare July 30, 2026 07:09
@beruro beruro closed this Jul 30, 2026
@beruro
beruro force-pushed the feat/team-inbox-lifecycle-fixed branch from c9277ea to cb96c41 Compare July 30, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants