Chore/enhance market overview data - #723
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances market overview data correctness and query efficiency across ticker and candle endpoints, plus adds a supporting DB index and tests.
Changes:
- Fixes ticker
openTime/closeTimeordering when buildingPriceChangeresults (including REST proxy fallback). - Adjusts candle query range calculation to request the latest
limitintervals when bounds are missing, and refactors interval parsing/shift logic. - Improves Postgres queries for ticker and candles (correct weighted average price, best bid/ask selection, and interval limiting), and adds a composite trades index.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| market/market-ports/market-persister-postgres/src/test/kotlin/co/nilin/opex/market/ports/postgres/impl/MarketQueryHandlerTest.kt | Adds tests for ticker time window ordering and candle bound fallback behavior. |
| market/market-ports/market-persister-postgres/src/main/resources/schema.sql | Adds (symbol, create_date) index to speed common trade lookups. |
| market/market-ports/market-persister-postgres/src/main/kotlin/co/nilin/opex/market/ports/postgres/impl/MarketQueryHandlerImpl.kt | Fixes ticker time window ordering and refactors candle time range derivation. |
| market/market-ports/market-persister-postgres/src/main/kotlin/co/nilin/opex/market/ports/postgres/dao/TradeRepository.kt | Corrects ticker aggregation math and improves candle query interval limiting/order. |
| api/api-ports/api-proxy-rest/src/main/kotlin/co/nilin/opex/api/ports/proxy/impl/MarketDataProxyImpl.kt | Fixes fallback PriceChange open/close time ordering. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AmirRajabii
approved these changes
Aug 19, 2026
AmirRajabii
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.