Add chain scanner url - #722
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the chain “scanner URL” concept by replacing the single external_chain_scanner_url with two distinct fields (transactionScannerUrl and addressScannerUrl) across the database schema, persistence layer, core model/SPI, and REST DTOs.
Changes:
- Adds two new scanner URL columns to the
chainstable and removes the previous single scanner URL column. - Updates
Chain/ChainModelandChainLoader.addChain(...)to carry transaction + address scanner URLs. - Updates admin + public controllers/DTOs (and API
ChainInfo) to expose the new fields.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| bc-gateway/bc-gateway-ports/bc-gateway-persister-postgres/src/main/resources/db/migration/V6__add_chain_scanner_urls.sql | Schema change: drop old scanner URL column, add two new URL columns. |
| bc-gateway/bc-gateway-ports/bc-gateway-persister-postgres/src/main/kotlin/co/nilin/opex/bcgateway/ports/postgres/model/ChainModel.kt | Persister model updated to include the two new URL fields. |
| bc-gateway/bc-gateway-ports/bc-gateway-persister-postgres/src/main/kotlin/co/nilin/opex/bcgateway/ports/postgres/impl/ChainHandler.kt | Loader implementation updated to accept/return the new URL fields. |
| bc-gateway/bc-gateway-core/src/main/kotlin/co/nilin/opex/bcgateway/core/spi/ChainLoader.kt | SPI updated to accept scanner URLs when adding a chain. |
| bc-gateway/bc-gateway-core/src/main/kotlin/co/nilin/opex/bcgateway/core/model/Chain.kt | Core model updated to include transaction/address scanner URLs. |
| bc-gateway/bc-gateway-app/src/main/kotlin/co/nilin/opex/bcgateway/app/service/AdminService.kt | Admin service forwards scanner URLs when creating a chain. |
| bc-gateway/bc-gateway-app/src/main/kotlin/co/nilin/opex/bcgateway/app/dto/ChainResponse.kt | REST response DTO updated to expose new scanner URL fields. |
| bc-gateway/bc-gateway-app/src/main/kotlin/co/nilin/opex/bcgateway/app/dto/AddChainRequest.kt | REST request DTO updated to accept new scanner URL fields. |
| bc-gateway/bc-gateway-app/src/main/kotlin/co/nilin/opex/bcgateway/app/controller/CryptoCurrencyController.kt | Public chain endpoint response updated for new DTO shape. |
| bc-gateway/bc-gateway-app/src/main/kotlin/co/nilin/opex/bcgateway/app/controller/AdminController.kt | Admin chain endpoint response updated for new DTO shape. |
| api/api-core/src/main/kotlin/co/nilin/opex/api/core/inout/ChainInfo.kt | API-facing chain info DTO updated to match bc-gateway response fields. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
fatemeh-i
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.