Skip to content

Add chain scanner url - #722

Merged
AmirRajabii merged 2 commits into
devfrom
add-chain-scanner-url
Aug 19, 2026
Merged

Add chain scanner url#722
AmirRajabii merged 2 commits into
devfrom
add-chain-scanner-url

Conversation

@AmirRajabii

Copy link
Copy Markdown
Contributor

No description provided.

@AmirRajabii
AmirRajabii requested a review from fatemeh-i August 19, 2026 11:21
@fatemeh-i
fatemeh-i requested a lite review from Copilot August 19, 2026 11:25
@fatemeh-i fatemeh-i changed the title add chain scanner url Add chain scanner url Aug 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the chain “scanner URL” concept by replacing the single external_chain_scanner_url with two distinct fields (transactionScannerUrl and addressScannerUrl) across the database schema, persistence layer, core model/SPI, and REST DTOs.

Changes:

  • Adds two new scanner URL columns to the chains table and removes the previous single scanner URL column.
  • Updates Chain / ChainModel and ChainLoader.addChain(...) to carry transaction + address scanner URLs.
  • Updates admin + public controllers/DTOs (and API ChainInfo) to expose the new fields.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
bc-gateway/bc-gateway-ports/bc-gateway-persister-postgres/src/main/resources/db/migration/V6__add_chain_scanner_urls.sql Schema change: drop old scanner URL column, add two new URL columns.
bc-gateway/bc-gateway-ports/bc-gateway-persister-postgres/src/main/kotlin/co/nilin/opex/bcgateway/ports/postgres/model/ChainModel.kt Persister model updated to include the two new URL fields.
bc-gateway/bc-gateway-ports/bc-gateway-persister-postgres/src/main/kotlin/co/nilin/opex/bcgateway/ports/postgres/impl/ChainHandler.kt Loader implementation updated to accept/return the new URL fields.
bc-gateway/bc-gateway-core/src/main/kotlin/co/nilin/opex/bcgateway/core/spi/ChainLoader.kt SPI updated to accept scanner URLs when adding a chain.
bc-gateway/bc-gateway-core/src/main/kotlin/co/nilin/opex/bcgateway/core/model/Chain.kt Core model updated to include transaction/address scanner URLs.
bc-gateway/bc-gateway-app/src/main/kotlin/co/nilin/opex/bcgateway/app/service/AdminService.kt Admin service forwards scanner URLs when creating a chain.
bc-gateway/bc-gateway-app/src/main/kotlin/co/nilin/opex/bcgateway/app/dto/ChainResponse.kt REST response DTO updated to expose new scanner URL fields.
bc-gateway/bc-gateway-app/src/main/kotlin/co/nilin/opex/bcgateway/app/dto/AddChainRequest.kt REST request DTO updated to accept new scanner URL fields.
bc-gateway/bc-gateway-app/src/main/kotlin/co/nilin/opex/bcgateway/app/controller/CryptoCurrencyController.kt Public chain endpoint response updated for new DTO shape.
bc-gateway/bc-gateway-app/src/main/kotlin/co/nilin/opex/bcgateway/app/controller/AdminController.kt Admin chain endpoint response updated for new DTO shape.
api/api-core/src/main/kotlin/co/nilin/opex/api/core/inout/ChainInfo.kt API-facing chain info DTO updated to match bc-gateway response fields.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@AmirRajabii
AmirRajabii merged commit 204eb1b into dev Aug 19, 2026
1 check passed
@AmirRajabii
AmirRajabii deleted the add-chain-scanner-url branch August 19, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants