Chore/optimize market accountant - #716
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR optimizes persistence behavior in the market Postgres persister by reducing duplicate-order write exceptions and loosening trade-duplicate detection around small timestamp differences.
Changes:
- Treat trades with matching payloads as duplicate deliveries even if
tradeDatediffers slightly (within a tolerance). - Replace order creation try/catch-on-duplicate with a Postgres
INSERT ... ON CONFLICT DO NOTHINGflow. - Add a custom repository insert query to support “insert if absent” semantics.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| market/market-ports/market-persister-postgres/src/main/kotlin/co/nilin/opex/market/ports/postgres/impl/TradePersisterImpl.kt | Adjusts duplicate-trade payload matching to allow small tradeDate deltas. |
| market/market-ports/market-persister-postgres/src/main/kotlin/co/nilin/opex/market/ports/postgres/impl/OrderPersisterImpl.kt | Uses repository-level insert-if-absent instead of catching duplicate insert exceptions. |
| market/market-ports/market-persister-postgres/src/main/kotlin/co/nilin/opex/market/ports/postgres/dao/OrderRepository.kt | Adds insertOrderIfAbsent query with ON CONFLICT (ouid) DO NOTHING. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AmirRajabii
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.