ci(zizmor): pin the zizmor binary version (stop ruleset drift) - #4
Conversation
Forward-port of EUDCH/.github#7 so both org reusable workflows match. The zizmor-action defaulted to version: latest, so zizmor's ruleset/online-audit set could drift and turn CI red across callers with no repo change. Pin to 1.26.1; new audits now arrive only on a deliberate bump.
There was a problem hiding this comment.
Pull request overview
Pins the zizmor binary version used by the reusable zizmor workflow so that zizmor’s ruleset/online-audit behavior doesn’t drift independently of the SHA-pinned zizmorcore/zizmor-action, preventing unexpected CI failures across downstream callers.
Changes:
- Add an explicit
version: "1.26.1"input to thezizmorcore/zizmor-actionstep. - Document why the binary version is pinned and that it should be bumped deliberately.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
_MREVIEW — Automated ReviewPlatform: GitHub | Ref: #4 | CI: none reported (normal — reusable-workflow repo, exercised by callers) Verdict: LGTM — correct forward-port of the merged EUDCH/.github#7. Ready to merge. I reviewed and validated the identical change on EUDCH/.github#7 already, so this is a confirm-it-matches pass:
Carried-over non-blocking notes (same as #7, accepted there): pinning the binary means new zizmor audits no longer arrive automatically — worth wiring Posted by |
Forward-port of EUDCH/.github#7 so both org reusable zizmor workflows match.
Problem
The reusable workflow SHA-pins
zizmor-actionbut leaves the zizmor binary at the action defaultversion: latest. So zizmor's ruleset and online-audit set drift independently of the pin, and a new or strengthened audit can flip CI red across every caller with no repo change. (On the EUDCH side this actually happened — aref-version-mismatchfinding surfaced on unchanged workflows.)Fix
Pin the binary:
version: "1.26.1"on thezizmor-actionstep. New audits now arrive only on a deliberate bump of this value, reviewable here.Notes
actionlintclean; callers re-pin@<sha>to adopt, as usual.