fix(index): preserve namespace package identity (0.0.46) - #29
Merged
Conversation
Sunrisepeak
marked this pull request as ready for review
July 25, 2026 06:11
Sunrisepeak
added a commit
to mcpplibs/mcpp-index
that referenced
this pull request
Jul 25, 2026
Upstream: openxlings/libxpkg#29. Related to openxlings/xlings#381.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
namespace:namewhile preserving the descriptorpackage.nameas the short lookup token0.0.46Root cause
build_index()keyed entries only bypackage.name(or a repository prefix), so two descriptors with the same short name could overwrite one another based on filesystem scan order. The index also lacked explicit identity and short-name candidate tables needed by xlings to diagnose ambiguity.Validation
mcpp buildmcpp test -- --gtest_filter=-ExecutorTest.ApplyElfpatchAuto_*(CI parity: 4 test binaries, 90 tests, 0 failures)git diff --checkRelated to openxlings/xlings#381.