-
Notifications
You must be signed in to change notification settings - Fork 3.9k
snowflake: update to 2.14.1 #30293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PolynomialDivision
wants to merge
1
commit into
openwrt:master
Choose a base branch
from
PolynomialDivision:snowflake-2-14-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2
−2
Open
snowflake: update to 2.14.1 #30293
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The runtime-test jobs fail on this bump because
snowflake-brokerandsnowflake-probetestproduce no version string:Same for
snowflake-probetest;-client,-proxyand-serverall print2.14.1and pass. The five failing jobs (x86_64, aarch64_generic, i386_pentium-mmx, arm_cortex-a15_neon-vfpv4, mips_24kc) are exactly the ones that run the runtime tests — the build-only architectures are green, so this is not a build regression.Worth a look before merge, since the 2.13.1 run in #29202 was green across the same matrix: either broker/probetest stopped emitting a version in 2.14.x, or the generic version test tightened since April. If it is the former (or if these two binaries simply never had a version flag), the feed's convention is to add a
net/snowflake/test-version.shthat returns 0 forsnowflake-brokerandsnowflake-probetestso the generic check is overridden for them, while the other three keep the real check. Your call on whether that belongs in this bump or a separate commit.Generated by Claude Code