Skip to content

luci-app-upnp: restore some i18n keys - #7433

Merged
systemcrash merged 2 commits into
openwrt:masterfrom
stokito:luci-app-upnp
Nov 30, 2024
Merged

luci-app-upnp: restore some i18n keys#7433
systemcrash merged 2 commits into
openwrt:masterfrom
stokito:luci-app-upnp

Conversation

@stokito

@stokito stokito commented Nov 30, 2024

Copy link
Copy Markdown
Contributor

Leftovers from #7407
CC @Self-Hosting-Group

Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
@systemcrash

Copy link
Copy Markdown
Contributor

These changes look fine

@stokito

stokito commented Nov 30, 2024

Copy link
Copy Markdown
Contributor Author

@Self-Hosting-Group there are two other unrestored keys but what is more important that you removed the cleanup_interval that should be restored.

@Self-Hosting-Group

Copy link
Copy Markdown
Contributor

@Self-Hosting-Group there are two other unrestored keys but what is more important that you removed the cleanup_interval that should be restored.

Please! Check the PR description/comments and the issue/PR upstreams. Analysis and doesn't work on OpenWrt for years, and you come very late with it.

@stokito

stokito commented Nov 30, 2024

Copy link
Copy Markdown
Contributor Author

If it doesn't work that may be a bug, I see something similar here #5774
I'm not sure if the options are actually needed at all even if they work but it may be used by someone. The main focus of your PR was on changing text but removing of the options was briefly mentioned so maybe wasn't noticed during a review.

@stokito
stokito marked this pull request as ready for review November 30, 2024 17:53
@systemcrash

Copy link
Copy Markdown
Contributor

There were previous attempts where there was... a lot of discussion. I'm fairly sure we went through those options that were removed.

@systemcrash
systemcrash merged commit 9c403f5 into openwrt:master Nov 30, 2024
@systemcrash

Copy link
Copy Markdown
Contributor

Merged, thanks @stokito !

@stokito
stokito deleted the luci-app-upnp branch November 30, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants