Skip to content

zyimage: make output byte order explicit #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lexfrei wants to merge 1 commit into
base: master
Choose a base branch
from
Open

zyimage: make output byte order explicit #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/zyimage.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
#include <sys/types.h>
#include <string.h>
#include <unistd.h>
#if defined(__linux__)
#include <endian.h>
#else
#include <sys/endian.h>
#endif

#define szbuf 32768

Expand Down Expand Up @@ -132,7 +137,15 @@ int main(int argc, char *argv[]) {
}

fseek(f, 0, SEEK_SET);
sign.crc32 = chksum_crc32(f);
/*
* On-disk fields are little-endian, matching every existing
* ZYIMAGE_ID value in the OpenWrt tree (unlike the vendor tool,
* which writes device_id big-endian). E.g. ZYIMAGE_ID 0x804410 and
* the vendor's CONFIG_TARGET_DEVICE_ID="0x10448000" are the same
* four bytes in opposite order.
*/
sign.device_id = htole32(sign.device_id);
sign.crc32 = htole32(chksum_crc32(f));
fwrite(&sign, sizeof(sign), 1, f);
fclose(f);

Expand Down