Adapt DNS alias API to new cname-records endpoints - #1069
Merged
cgalibern merged 1 commit intoJul 20, 2026
Conversation
PaulJouvanceau
commented
Jul 17, 2026
PaulJouvanceau
commented
Contributor
- Change the none target constant to "none.ocp"
- Update Alias struct JSON tag for ZoneID to "zoneId"
- Migrate API endpoints:
- GET /zones/{zoneID}/cname-records?name=...&id=...
- POST /zones/{zoneID}/cname-records
- PATCH /zones/{zoneID}/cname-records/{uuid} (target only)
- DELETE /zones/{zoneID}/cname-records/{uuid}
- Parse response using "cnameRecords" field instead of "aliases"
- Adjust helper and tests to match new API contract
PaulJouvanceau
force-pushed
the
feat/dns-alias-cname-records
branch
2 times, most recently
from
July 20, 2026 08:26
6c76af9 to
5d505aa
Compare
- Change the none target constant to "none.ocp"
- Update Alias struct JSON tag for ZoneID to "zoneId"
- Migrate API endpoints:
- GET /zones/{zoneID}/cname-records?name=...&id=...
- POST /zones/{zoneID}/cname-records
- PATCH /zones/{zoneID}/cname-records/{uuid} (target only)
- DELETE /zones/{zoneID}/cname-records/{uuid}
- Parse response using "cnameRecords" field instead of "aliases"
- Adjust helper and tests to match new API contract
PaulJouvanceau
force-pushed
the
feat/dns-alias-cname-records
branch
from
July 20, 2026 08:44
5d505aa to
66a6495
Compare
cgalibern
approved these changes
Jul 20, 2026
| ) | ||
|
|
||
| const noneTarget = "none." | ||
| const noneTarget = "none.ocp" |
Contributor
There was a problem hiding this comment.
Can tou move the none target value inside the sgcp.yaml ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.