OU-1466: swap dashboard-list-page to use shared table setup

[PeterYurkovich]

Summary by CodeRabbit

• Improvements
  • Updated the dashboard list’s filtering, sorting, pagination, and column controls for a more consistent table experience.
  • Improved sorting consistency and determinism for dashboard name, project, created, and modified fields.
  • Moved the “Clear all filters” action into the table toolbar for easier access and streamlined controls.
  • Preserved existing dashboard actions (renaming, duplicating, and deleting) and kept row content unchanged.

[openshift-ci-robot]

@PeterYurkovich: This pull request references OU-1466 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• web/src/features/perses-dashboards/OWNERS [PeterYurkovich]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e83adf2f-bb86-40c4-893b-3b143ac8faaa

📥 Commits

Reviewing files that changed from the base of the PR and between a1dfb57 and d2fa140.

📒 Files selected for processing (1)

• web/src/features/perses-dashboards/pages/dashboard-list-page/DashboardList.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

• web/src/features/perses-dashboards/pages/dashboard-list-page/DashboardList.tsx

---

Walkthrough

DashboardList migrates dashboard table controls from PatternFly data-view wiring to shared table abstractions, including filtering, pagination, columns, toolbar rendering, and locale-aware sorting. Dashboard row actions and overall list rendering remain in place.

Changes

Dashboard table controls

Layer / File(s)	Summary
Shared table state and row processing web/src/features/perses-dashboards/pages/dashboard-list-page/DashboardList.tsx	PatternFly data-view hooks are replaced with shared filter, pagination, and column hooks. Dashboard rows are filtered and sorted through a consolidated memo using explicit dashboard field keys and locale-aware comparisons.
Shared toolbar and table integration web/src/features/perses-dashboards/pages/dashboard-list-page/DashboardList.tsx	The toolbar uses shared filter components, adapts filter changes while resetting pagination, and provides filter clearing. The table consumes shared columns, the empty state no longer renders its own clear-filters button, and dashboard action items use a typed shape.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: jgbernalp, zhuje

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: dashboard-list-page now uses the shared table setup.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only DashboardList.tsx changed; no test files or It/Describe/Context/When titles were added, so no unstable Ginkgo names to flag.
Test Structure And Quality	✅ Passed	Patch only touches DashboardList.tsx UI code; no Ginkgo tests were added or modified, so this check is not applicable.
Microshift Test Compatibility	✅ Passed	Only a TSX dashboard page changed; no new Ginkgo e2e tests or MicroShift-sensitive OpenShift APIs were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only changes a React dashboard page (DashboardList.tsx); no new Ginkgo e2e tests or topology-sensitive node assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a frontend dashboard-list refactor changed; no manifests, controllers, replicas, affinity, node selectors, or PDBs were added.
Ote Binary Stdout Contract	✅ Passed	The only changed file is a React TSX page; it has no process-level code or stdout writes (no console/log/klog/main/TestMain found).
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No Ginkgo e2e tests were added; the only touched file is a frontend TSX page with no test blocks or network/IP assumptions.
No-Weak-Crypto	✅ Passed	Only DashboardList.tsx changed; it contains UI/table logic and no weak crypto, custom crypto, or secret/token comparisons.
Container-Privileges	✅ Passed	The PR only changes DashboardList.tsx; the diff contains no privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	DashboardList.tsx contains no console/logger calls or other sensitive-data logging; changes are table/filter refactors only.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@web/src/features/perses-dashboards/pages/dashboard-list-page/DashboardList.tsx`:
- Around line 184-194: Update the column definitions in DashboardList around
columnKeys and useTableColumns so columns includes a fifth non-sortable actions
column matching the action cell supplied by pageRows. Give it an accessible
header label and ensure it is not sortable, preserving the existing four
sortable columns.
- Around line 134-154: Add a co-located DashboardList.spec.ts covering the
migrated table behavior: filtering, sorting, URL-backed pagination, and applying
a filter while viewing a later page. Exercise sortDashboardData and the
DashboardList pagination/filter interactions using the existing frontend testing
conventions.
- Around line 324-330: Update the onFiltersChange callback to reset the
dashboard list pagination to page 1 whenever a filter is applied, before or
alongside onSetFilters. Reuse the existing pagination state setter and preserve
the current filter update behavior, including any required dependency updates
for the useMemo callback.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3a2d2987-4185-41da-b99f-1fc4affe20e5

📥 Commits

Reviewing files that changed from the base of the PR and between 64145df and a1dfb57.

📒 Files selected for processing (1)

• web/src/features/perses-dashboards/pages/dashboard-list-page/DashboardList.tsx

[PeterYurkovich]

/retest ci/prow/e2e-monitoring

[PeterYurkovich]

/test ci/prow/e2e-monitoring

[PeterYurkovich]

/test e2e-monitoring

[etmurasaki]

/label qe-approved

[openshift-ci]

@PeterYurkovich: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.