USHIFT-7405: pass timeout to oc wait in Named VolumeSnapshot Should B…

[pacevedom]

…e Ready

The keyword accepted a timeout parameter but never forwarded it to the Oc Wait call, causing oc wait to use its 30s default instead of the intended 120s DEFAULT_WAIT_TIMEOUT.

Summary by CodeRabbit

• Bug Fixes
  • Volume snapshot readiness checks now honor the configured timeout, preventing waits from running indefinitely.

[openshift-ci-robot]

@pacevedom: This pull request references USHIFT-7405 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

…e Ready

The keyword accepted a timeout parameter but never forwarded it to the Oc Wait call, causing oc wait to use its 30s default instead of the intended 120s DEFAULT_WAIT_TIMEOUT.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [pacevedom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5731fc32-21e7-4671-a1a2-587c22026211

📥 Commits

Reviewing files that changed from the base of the PR and between bea592e and 9ac0ac3.

📒 Files selected for processing (1)

• test/resources/oc.resource

🚧 Files skipped from review as they are similar to previous changes (1)

• test/resources/oc.resource

---

Walkthrough

The VolumeSnapshot readiness keyword now forwards its configured timeout to the underlying Oc Wait command.

Changes

VolumeSnapshot readiness

Layer / File(s)	Summary
Forward readiness wait timeout test/resources/oc.resource	Adds --timeout=${timeout} when waiting for volumesnapshot/${name} to reach .status.readyToUse=true.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: agullon, eslutsky

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly states the main change: passing timeout to oc wait for the VolumeSnapshot check.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only changes a Robot keyword to pass ${timeout} to Oc Wait; no Ginkgo-style test titles were added or modified.
Test Structure And Quality	✅ Passed	PASS: The change forwards ${timeout} to oc wait, and the snapshot suite already uses setup/teardown patterns; no quality regressions are introduced.
Microshift Test Compatibility	✅ Passed	PR only updates a Robot keyword in test/resources/oc.resource; no new Ginkgo e2e tests or MicroShift-unsupported APIs/features are introduced.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The PR only tweaks a Robot Framework helper in test/resources/oc.resource; it adds a timeout to oc wait and introduces no new Ginkgo tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a Robot test keyword changed to pass timeout through; no manifests, operators, or controllers were modified.
Ote Binary Stdout Contract	✅ Passed	PR only edits a test resource to pass a timeout to Oc Wait; no main/init/TestMain/suite setup stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The change only updates a Robot Framework helper in test/resources/oc.resource; no new Ginkgo test, IPv4 hardcodes, or external connectivity were added.
No-Weak-Crypto	✅ Passed	The PR only forwards a timeout in test/resources/oc.resource; no weak crypto, custom crypto, or secret comparisons are introduced.
Container-Privileges	✅ Passed	Only test/resources/oc.resource changed, and it just forwards a timeout to oc wait; no container/K8s manifest or privilege settings were added.
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The patch only forwards --timeout to oc wait; no new logs or sensitive fields were added, and existing logging is generic.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.