OU-1416 OU-1415 fix histogram and table colors themes, fix volume legend background - #389
Open
zhuje wants to merge 3 commits into
Open
Conversation
…d background Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhuje The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
WalkthroughLog severity indicators now use CSS variables applied through virtualized row styles. The metrics legend table receives transparent sticky-cell backgrounds, and Cypress tests synchronize required network requests and query edits. ChangesLogs UI and test updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
web/src/components/virtualized-logs-table.tsx (1)
223-223: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winPreserve virtualization layout styles.
getRowStyleis spread after the react-virtualizedstyle, so any callback returningtop,height,width, orpositioncan break row placement. Apply the callback first; the severity custom property will still be retained.Proposed fix
- style={{ ...style, ...getRowStyle?.(rowArgs.obj) }} + style={{ ...getRowStyle?.(rowArgs.obj), ...style }}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/src/components/virtualized-logs-table.tsx` at line 223, Update the row style merge in the virtualized logs table so getRowStyle?.(rowArgs.obj) is applied before the react-virtualized style, ensuring virtualization-controlled top, height, width, and position values always win while retaining custom properties such as severity.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@web/src/components/virtualized-logs-table.tsx`:
- Line 223: Update the row style merge in the virtualized logs table so
getRowStyle?.(rowArgs.obj) is applied before the react-virtualized style,
ensuring virtualization-controlled top, height, width, and position values
always win while retaining custom properties such as severity.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 42269667-8ee4-48e9-9005-0f26be620821
📒 Files selected for processing (6)
web/src/components/logs-metrics.cssweb/src/components/logs-metrics.tsxweb/src/components/logs-table.cssweb/src/components/logs-table.tsxweb/src/components/virtualized-logs-table.tsxweb/src/severity.ts
Contributor
Author
|
/retest |
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/cypress/e2e/integration/logs-dev-page.cy.ts`:
- Around line 444-449: Update the second ExecuteQueryButton interaction in the
query test to use the queryRangeStreams alias and wait for that request to
complete before asserting histogram or button state. Remove force: true from
this click so Cypress retains its actionability checks, while preserving the
existing synchronized first query flow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: d7c1586c-77ff-437b-baa1-dcc02bc4e2d6
📒 Files selected for processing (1)
web/cypress/e2e/integration/logs-dev-page.cy.ts
zhuje
force-pushed
the
ou1416-ou1415-fix-histogram-n-legend-color-themes
branch
from
July 28, 2026 21:46
78379ad to
8a4ca1b
Compare
Contributor
|
@zhuje: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
|
||
| const getSeverityClass = (severity: string) => { | ||
| return severity ? `lv-plugin__table__severity-${severity}` : ''; | ||
| const getRowSeverityStyle = (severity: string): CSSProperties => { |
Contributor
There was a problem hiding this comment.
Changes in this file aren't needed. We can just have the function live in virtualized-log-table.tsx and not need to pass it in as a prop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA
https://redhat.atlassian.net/browse/OU-1416
https://redhat.atlassian.net/browse/OU-1415
Note: Update chart colors associates to align with patternfly guidelines https://www.patternfly.org/ai/guidelines/color/#color-associations-and-statuses
Image
quay.io/jezhu/logging-view-plugin:ou1416-ou1415-jul17
Screenshots
Figure. Fix log volume legend background to be transparent (OU-1416)
Figure. Fix histogram and table row colors to match (OU-1415)
Summary by CodeRabbit
Summary by CodeRabbit
Bug Fixes
Accessibility
aria-labeland applying a dedicated styling class.Tests