WIP [llm-d] feat: Add new EPP profiles - #185
Conversation
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
…omo2/forge into feat/precise-prefix-cache-v2
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
🟢 Execution of
|
🟢 Execution of
|
| # The serving image expands VLLM_ADDITIONAL_ARGS through `eval`; literal | ||
| # single quotes keep the JSON intact for vLLM after that shell parse. | ||
| kv_events_config: "'{\"enable_kv_cache_events\": true, \"publisher\": \"zmq\", \"endpoint\": \"tcp://__INFERENCE_SERVICE_NAME__-epp-service:5557\", \"topic\": \"kv@$(POD_IP)@$(MODEL_NAME)\"}'" | ||
| kv_events_config: "'{\"enable_kv_cache_events\": true, \"publisher\": \"zmq\", \"endpoint\": \"tcp://*:5556\", \"topic\": \"kv@$(POD_IP)@$(MODEL_NAME)\"}'" |
There was a problem hiding this comment.
FYI, I started reworking this in my PR, to make this more flexible
I hope it will work for you 🤞🏻
There was a problem hiding this comment.
yes, no problem! I'll rebase and adapt it when you are done 👌
🟢 Execution of
|
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
🔴 Execution of
|
🔴 Execution of
|
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
🔴 Execution of
|
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
🟢 Execution of
|
No description provided.