fix: update missmatch param in queryset_builder for scopes#367
Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
mariajgrimaldi
left a comment
There was a problem hiding this comment.
Looks good! Thanks a lot :)
Can we do a patch bump for a release?
Description
_get_allowed_scope_querysetis generic over two builders whose first parameter differs by design —_get_courses_queryset(allowed_ids=…)vs_get_libraries_queryset(allowed_pairs=…)(libraries key on org+slug pairs). The normal path (line 848) passes that arg positionally, so it works for both. But the platform-access shortcut at line 843 passed it as the keywordallowed_ids=None, which the libraries builder doesn't accept; hence theTypeError, triggered only when the requesting user has platform-wide access.Testing instructions
Merge checklist:
Check off if complete or not applicable: