Skip to content

fix: update missmatch param in queryset_builder for scopes#367

Merged
mariajgrimaldi merged 2 commits into
openedx:mainfrom
eduNEXT:dcoa/fix-wide-lib
Jul 24, 2026
Merged

fix: update missmatch param in queryset_builder for scopes#367
mariajgrimaldi merged 2 commits into
openedx:mainfrom
eduNEXT:dcoa/fix-wide-lib

Conversation

@dcoa

@dcoa dcoa commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Description

_get_allowed_scope_queryset is generic over two builders whose first parameter differs by design — _get_courses_queryset(allowed_ids=…) vs _get_libraries_queryset(allowed_pairs=…) (libraries key on org+slug pairs). The normal path (line 848) passes that arg positionally, so it works for both. But the platform-access shortcut at line 843 passed it as the keyword allowed_ids=None, which the libraries builder doesn't accept; hence the TypeError, triggered only when the requesting user has platform-wide access.

image

Testing instructions

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jul 23, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @dcoa!

This repository is currently maintained by @openedx/committers-openedx-authz.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@dcoa
dcoa requested a review from mariajgrimaldi July 23, 2026 02:33
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jul 23, 2026
@dcoa
dcoa requested review from BryanttV and efortish July 23, 2026 02:33
Comment thread .python-version Outdated
Comment thread openedx_authz/rest_api/v1/views.py Outdated
@dcoa
dcoa force-pushed the dcoa/fix-wide-lib branch from ec89484 to 2c88e0b Compare July 24, 2026 02:31
@dcoa
dcoa requested a review from mariajgrimaldi July 24, 2026 02:31

@mariajgrimaldi mariajgrimaldi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks a lot :)

Can we do a patch bump for a release?

@mariajgrimaldi mariajgrimaldi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@mariajgrimaldi
mariajgrimaldi merged commit 52b6763 into openedx:main Jul 24, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Jul 24, 2026
@mariajgrimaldi

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants