Skip to content

feat: add tenant selection store (TenantStore) - #673

Open
RawanMatar89 wants to merge 5 commits into
openedx:developfrom
zeit-labs:infra/02-tenant-store
Open

feat: add tenant selection store (TenantStore)#673
RawanMatar89 wants to merge 5 commits into
openedx:developfrom
zeit-labs:infra/02-tenant-store

Conversation

@RawanMatar89

@RawanMatar89 RawanMatar89 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds TenantStore: single source of truth for the selected tenant and the tenant catalog, persisted to UserDefaults, posting .tenantDidChange for observers. Still foundation — nothing in the app resolves or calls it yet.

Included

  • TenantStore (Core): selection state + catalog, auto-selects the sole tenant on a single-tenant catalog (no picker to choose it through otherwise)
  • Registered in NetworkAssembly (TenantStore / TenantProvider)
  • TenantStoreTests.swift — 8 unit tests

Not included

  • Any real consumer (RequestInterceptor, storage, session lifecycle) — starts in later PRs
  • Remote catalog fetch (TenantConfigLoader) — separate PR

Fixed in passing

The original TenantStoreTests.swift was never added to Core.xcodeproj, so it silently never ran as part of CoreTests. Registered it correctly since this PR is what introduces the file.

Testing

Built and ran successfully on device.


Note

This is the 2nd pull-request of the multi-tenant infrastructure extraction.

RawanMatar89 and others added 5 commits June 22, 2026 23:24
fix: typo in translation.py inline comments
Adds the Sendable Tenant value type and TenantsConfig container that
later multi-tenant layers build on: per-tenant API/SSO/OAuth config,
UI feature flags (UIComponentsConfig, now @unchecked Sendable), and
raw branding fields for a later theming layer to render.

Tenant(dictionary:) parses config.yaml's new TENANTS block.

Not included here: remote catalog fetching, tenant selection/session
state, and anything reading TenantProvider — those land as separate
PRs. TENANTS data in config.yaml is illustrative, not real tenants.
Adds TenantStore: the single source of truth for the selected tenant
and the tenant catalog, persisted to UserDefaults and posting
.tenantDidChange for observers. Auto-selects the sole tenant on a
single-tenant catalog, since there's no picker to choose it through.

Registered in NetworkAssembly (TenantStore/TenantProvider). Not
consumed by anything yet — RequestInterceptor and the rest of the
storage/session layers read it starting in later PRs.

Also fixes a real gap found while extracting this: the original
TenantStoreTests.swift was never added to Core.xcodeproj, so it
silently never ran as part of CoreTests.
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Sep 2, 2026
@openedx-webhooks

openedx-webhooks commented Sep 2, 2026

Copy link
Copy Markdown

Thanks for the pull request, @RawanMatar89!

This repository is currently maintained by @openedx/openedx-mobile-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Sep 2, 2026
@RawanMatar89
RawanMatar89 marked this pull request as ready for review September 2, 2026 12:45
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (0c72bd4) to head (d1657e7).

Additional details and impacted files
@@      Coverage Diff       @@
##   develop   #673   +/-   ##
==============================
==============================

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

4 participants